10 days for us. It gives you the opportunity to take a night off here and there or even hit the room a bit early . Seven nights you have to go full out on each.
We always do 10 days to 2 weeks. Lately it's been consistently 2 weeks! That way you're not as worried about taking it easy a night or 2. You may also choose to escape the pace of the resort and visit Isla Mujeres or go shopping one day. The airfare is the same big cash outlay whether your trip is 5 days or 15! My 2 cents.
We noticed your mention of scuba diving while at TTR. We did so during our second trip as a mid-trip break from the mayhem of the resort. Our take-away point was that after staying stone cold sober (dive regulations) for the afternoon then returning to the Sexy Pool at 4pm, when it's in full swing, was a sight we'll never forget. Envision walking completely sober into the wildest club in any major city at 11:59pm on NYE. Fun times!
We've done 4 nights twice within 4 months, and we're doing 5 nights in April. 4 nights definitely leaves you wanting more, which is why we went back 4 months later. I'd like to do 7, but we've had a baby at home each trip and the wife understandably doesn't wanna be away that long.
First time we went for 10 days.. seemed a little long, last time we went for 8/9 days, seemed about perfect.. more depends on how much you drink and how well you recover but just booked our May trip for 9 days again...